Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the server temp file a one-off and explicitly delete it #862

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Jul 5, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Jul 5, 2024 that may be closed by this pull request
@Ellpeck Ellpeck requested a review from EagleoutIce July 5, 2024 09:13
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (1606c4f) to head (1389caf).

Files Patch % Lines
src/cli/repl/server/connection.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   71.76%   71.76%   -0.01%     
==========================================
  Files         202      202              
  Lines        7350     7346       -4     
  Branches     1245     1244       -1     
==========================================
- Hits         5275     5272       -3     
  Misses       1709     1709              
+ Partials      366      365       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit e955317 into main Jul 5, 2024
23 checks passed
@EagleoutIce EagleoutIce deleted the 860-ensure-the-servers-temporary-file-gets-closed branch July 5, 2024 09:25
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.12 (see Release v2.0.12 (Guard Against Shell-Escapes and Multi-File Support)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the server's temporary file gets closed
2 participants