Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-fix: only print ids in may refernces #847

Merged

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Jun 25, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (6078504) to head (70467e1).

Files Patch % Lines
src/util/mermaid/dfg.ts 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #847    +/-   ##
========================================
  Coverage   71.75%   71.75%            
========================================
  Files         202      202            
  Lines        7340     7340            
  Branches     1245     1137   -108     
========================================
  Hits         5267     5267            
  Misses       1708     1708            
  Partials      365      365            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit e17e967 into main Jun 25, 2024
24 checks passed
@EagleoutIce EagleoutIce deleted the 846-bug-mermaid-produces-object-object-for-cd-in-dfg branch June 25, 2024 07:54
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.10 (see Release v2.0.10 (Fix: Correctly print CDs in mermaid)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mermaid produces [object Object] for CD in DFG
1 participant