Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include times per line in statistics #830

Merged
merged 14 commits into from
Jun 1, 2024
Merged

Include times per line in statistics #830

merged 14 commits into from
Jun 1, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented May 29, 2024

No description provided.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.92%. Comparing base (d347535) to head (44f7a64).

Files Patch % Lines
src/benchmark/summarizer/first-phase/process.ts 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   71.84%   71.92%   +0.08%     
==========================================
  Files         202      202              
  Lines        7274     7296      +22     
  Branches     1125     1227     +102     
==========================================
+ Hits         5226     5248      +22     
- Misses       1691     1694       +3     
+ Partials      357      354       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck
Copy link
Member Author

Ellpeck commented May 30, 2024

TODO: standard deviation for 1 run is 0 because it gets summarized from just one run, and then the standard deviation for the total is also 0 because it gets calculated based on the other standard deviations. that's wrong & bad

This and a lot of other problems will be solved by flipping summarization order (currently we summarize all runs of a file first, then summarize over those. we should be summarizing all files of the nth run, and then summarizing all runs)

@Ellpeck Ellpeck marked this pull request as ready for review May 31, 2024 13:41
@Ellpeck Ellpeck requested a review from EagleoutIce May 31, 2024 13:41
@EagleoutIce EagleoutIce merged commit 492d264 into main Jun 1, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the stats-times branch June 1, 2024 21:14
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.3 (see Release v2.0.3 (Fine-Grained Benchmarks)).

1 similar comment
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.3 (see Release v2.0.3 (Fine-Grained Benchmarks)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants