Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older R versions #828

Merged
merged 13 commits into from
Jun 2, 2024
Merged

Support older R versions #828

merged 13 commits into from
Jun 2, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented May 28, 2024

No description provided.

@Ellpeck Ellpeck linked an issue May 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.92%. Comparing base (f52a2e4) to head (64a0fa3).
Report is 2 commits behind head on main.

Files Patch % Lines
src/r-bridge/lang-4.x/ast/parser/json/format.ts 66.66% 1 Missing ⚠️
...4.x/ast/parser/xml/internal/loops/normalize-for.ts 0.00% 0 Missing and 1 partial ⚠️
...ng-4.x/ast/parser/xml/internal/normalize-access.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   71.92%   71.92%   -0.01%     
==========================================
  Files         202      202              
  Lines        7296     7298       +2     
  Branches     1124     1124              
==========================================
+ Hits         5248     5249       +1     
- Misses       1694     1695       +1     
  Partials      354      354              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce self-assigned this Jun 2, 2024
@EagleoutIce
Copy link
Member

This will now be handled in stages, the first PR adds the support for 3.6.x

@EagleoutIce EagleoutIce marked this pull request as ready for review June 2, 2024 14:01
@EagleoutIce EagleoutIce merged commit 421e279 into main Jun 2, 2024
30 checks passed
@EagleoutIce EagleoutIce deleted the 819-support-older-r-versions branch June 2, 2024 14:02
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.5 (see Release v2.0.5 (Support for R 3.6.0)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support older R versions
2 participants