Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistencies when analyzing unnamed closures #823

Merged

Conversation

EagleoutIce
Copy link
Member

@EagleoutIce EagleoutIce commented May 24, 2024

Furthermore, this

  • improves mermaid's printing of expression lists when the lexeme is unknown.
  • simplifies the flag for named and unnamed function calls as a boolean

@EagleoutIce EagleoutIce linked an issue May 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 77.55102% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 71.69%. Comparing base (43a4ef5) to head (dfa43d0).

Files Patch % Lines
src/util/mermaid/dfg.ts 60.00% 0 Missing and 4 partials ⚠️
src/util/mermaid/ast.ts 33.33% 2 Missing ⚠️
...ess/functions/call/built-in/built-in-assignment.ts 50.00% 0 Missing and 1 partial ⚠️
src/reconstruct/reconstruct.ts 85.71% 0 Missing and 1 partial ⚠️
src/slicing/criterion/filters/all-variables.ts 0.00% 0 Missing and 1 partial ⚠️
...c/statistics/features/common-syntax-probability.ts 0.00% 0 Missing and 1 partial ⚠️
...s/supported/defined-functions/defined-functions.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   71.76%   71.69%   -0.07%     
==========================================
  Files         201      201              
  Lines        7239     7243       +4     
  Branches     1221     1122      -99     
==========================================
- Hits         5195     5193       -2     
- Misses       1689     1693       +4     
- Partials      355      357       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit 997c114 into main May 24, 2024
23 checks passed
@EagleoutIce EagleoutIce deleted the 821-inconsistencies-when-reconstructing-with-closures branch May 24, 2024 22:38
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistencies when reconstructing with closures
1 participant