Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mermaid printing, assign ids, and environment references #811

Merged
merged 7 commits into from
May 21, 2024

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue May 21, 2024 that may be closed by this pull request
@EagleoutIce
Copy link
Member Author

This should fix #810 (and improve a lot more), but the tests should be implemented by #800.

@EagleoutIce EagleoutIce requested a review from Ellpeck May 21, 2024 11:04
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@1dcff63). Learn more about missing BASE report.

Files Patch % Lines
src/dataflow/environments/diff.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage        ?   71.74%           
=======================================
  Files           ?      201           
  Lines           ?     7214           
  Branches        ?     1114           
=======================================
  Hits            ?     5176           
  Misses          ?     1686           
  Partials        ?      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit 00f3933 into main May 21, 2024
23 checks passed
@EagleoutIce EagleoutIce deleted the 810-question-inconclusive-dataflow-graph branch May 21, 2024 15:50
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

1 similar comment
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Inconclusive dataflow graph
1 participant