Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mermaid Escaping #808

Conversation

EagleoutIce
Copy link
Member

Now, we use the html shortcodes to avoid escaping problems.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (f1debbb) to head (e365865).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   71.78%   71.79%   +0.01%     
==========================================
  Files         201      201              
  Lines        7199     7202       +3     
  Branches     1211     1110     -101     
==========================================
+ Hits         5168     5171       +3     
  Misses       1681     1681              
  Partials      350      350              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce
Copy link
Member Author

Currently, Oparu is down, which explains the failing tests.

@EagleoutIce EagleoutIce merged commit 05d777a into main May 21, 2024
23 checks passed
@EagleoutIce EagleoutIce deleted the 807-checking-expected-output-for-tests-doesnt-seem-to-cause-the-shell-to-be-cleaned-up branch May 21, 2024 13:32
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking expected output for tests doesn't seem to cause the shell to be cleaned up
1 participant