Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark: compare reductions without comments and empty lines #797

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented May 17, 2024

No description provided.

@Ellpeck Ellpeck linked an issue May 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 89.04110% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.82%. Comparing base (d370560) to head (48698aa).

Files Patch % Lines
src/benchmark/slicer.ts 83.33% 2 Missing and 1 partial ⚠️
src/benchmark/summarizer/first-phase/process.ts 92.68% 2 Missing and 1 partial ⚠️
src/benchmark/stats/print.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   71.74%   71.82%   +0.08%     
==========================================
  Files         201      201              
  Lines        7142     7192      +50     
  Branches     1099     1210     +111     
==========================================
+ Hits         5124     5166      +42     
- Misses       1673     1679       +6     
- Partials      345      347       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck

This comment was marked as outdated.

@Ellpeck Ellpeck marked this pull request as ready for review May 17, 2024 12:37
@Ellpeck Ellpeck requested a review from EagleoutIce May 17, 2024 12:37
@EagleoutIce EagleoutIce merged commit 1f92d6e into main May 18, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 795-benchmark-should-compare-line-reductions-without-comment-and-empty-lines branch May 18, 2024 10:33
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark should compare reductions without comment and empty lines
2 participants