Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for names in the Dataflow Graph #776

Merged

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented May 8, 2024

No description provided.

@Ellpeck Ellpeck linked an issue May 8, 2024 that may be closed by this pull request
@Ellpeck Ellpeck requested a review from EagleoutIce May 8, 2024 12:43
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.77%. Comparing base (eeb85db) to head (a05eec4).

Files Patch % Lines
src/util/mermaid/dfg.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files         163      162    -1     
  Lines        4685     4687    +2     
  Branches      781      854   +73     
=======================================
+ Hits         3784     3786    +2     
+ Misses        631      630    -1     
- Partials      270      271    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dataflow/internal/linker.ts Outdated Show resolved Hide resolved
test/functionality/dataflow/graph/equal-tests.ts Outdated Show resolved Hide resolved
@Ellpeck Ellpeck requested a review from EagleoutIce May 8, 2024 15:07
@EagleoutIce EagleoutIce merged commit 7ff0c48 into main May 8, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 771-remove-the-need-for-names-in-the-dataflow-graph branch May 8, 2024 15:57
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

1 similar comment
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the need for names in the Dataflow Graph
2 participants