Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure low logging level on npm by default #717

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 11, 2024

All exisiting extension points, like the repl, the slicer and the tests, automatically set their log level to their desired level already, so this change will only have an effect on the npm package.

@Ellpeck Ellpeck linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.12%. Comparing base (d4ad9bd) to head (e369b3a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   71.13%   71.12%   -0.02%     
==========================================
  Files         217      217              
  Lines        7033     7033              
  Branches     1095     1095              
==========================================
- Hits         5003     5002       -1     
  Misses       1738     1738              
- Partials      292      293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit b24ba32 into main Mar 11, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 709-ensure-low-logging-level-on-npm-by-default branch March 11, 2024 14:59
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure low logging level on npm by default
2 participants