Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Require Parenthesis with new #671

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Feb 23, 2024

added the rule and fixed resulting style inconsistencies

@Ellpeck Ellpeck linked an issue Feb 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.60%. Comparing base (fac0a71) to head (deeed53).

Files Patch % Lines
...ics/features/supported/assignments/post-process.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   71.60%   71.60%           
=======================================
  Files         219      219           
  Lines        7142     7142           
  Branches     1103     1103           
=======================================
  Hits         5114     5114           
  Misses       1737     1737           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit 311c0b8 into main Feb 23, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 667-always-require-parenthesis-with-new branch February 23, 2024 13:24
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always Require Parenthesis with new
2 participants