Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert - Expression injection in Actions #603

Merged

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Jan 18, 2024

I don't know if this'll make the backtick issue still work, but since it says that it "prevents the attack", I assume it means it disallows code execution in any way, ie it causes it to be sanitized?

Let's wait and see?

@Ellpeck Ellpeck linked an issue Jan 18, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f464716) 71.08% compared to head (53d55da) 71.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files         213      213           
  Lines        6774     6774           
  Branches     1053     1053           
=======================================
  Hits         4815     4815           
  Misses       1685     1685           
  Partials      274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit 51fa796 into main Jan 18, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 602-fix-code-scanning-alert-expression-injection-in-actions branch January 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Expression injection in Actions
2 participants