Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint on git with clean history #411

Merged
merged 16 commits into from
Oct 14, 2023
Merged

Lint on git with clean history #411

merged 16 commits into from
Oct 14, 2023

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Oct 13, 2023 that may be closed by this pull request
Lint on git commit stage #406
Closed
@EagleoutIce
Copy link
Member Author

Still has to be tested on windows

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@EagleoutIce
Copy link
Member Author

Verified

LukasPietzschmann
LukasPietzschmann requested changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@LukasPietzschmann LukasPietzschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not messing with the local version would be better. The overhead in copying the whole project to another folder is not great either, but (at least for me) it feels way better than stashing all the changes away while somebody could be working on them.

@EagleoutIce
Copy link
Member Author

Again: verified on windows!

@EagleoutIce EagleoutIce merged commit 055f0fa into main Oct 14, 2023
20 checks passed
@EagleoutIce EagleoutIce deleted the 406-lint-on-git-commit-stage branch October 14, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasPietzschmann LukasPietzschmann LukasPietzschmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint on git commit stage
2 participants
@EagleoutIce @LukasPietzschmann