Skip to content

Commit

Permalink
Don’t Automatically Run License Checker Locally (#497)
Browse files Browse the repository at this point in the history
lint: do not run license checker with local lint rule as it may produce different results depending on the operating system
  • Loading branch information
EagleoutIce committed Nov 13, 2023
1 parent e80e1c7 commit a99a7f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"summarizer": "ts-node src/cli/summarizer-app.ts",
"export-quads": "ts-node src/cli/export-quads-app.ts",
"build": "tsc --project .",
"lint-local": "npm run lint -- --rule \"no-warning-comments: off\"",
"lint-local": "eslint src/ test/ --rule \"no-warning-comments: off\"",
"lint": "npm run license-compat -- --summary && eslint src/ test/",
"license-compat": "license-checker --onlyAllow 'MIT;MIT OR X11;GPLv2;LGPL;GNUGPL;ISC;Apache-2.0;FreeBSD;BSD-2-Clause;clearbsd;ModifiedBSD;BSD-3-Clause;Python-2.0;Unlicense;WTFPL;CC-BY-4.0;CC-BY-3.0;CC0-1.0;0BSD'",
"doc": "typedoc",
Expand Down

2 comments on commit a99a7f8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"artificial" Benchmark Suite

Benchmark suite Current: a99a7f8 Previous: 243959c Ratio
Total per-file 3194.7415548636363 ms (3611.936727164725) 3190.570812409091 ms (3747.790963743062) 1.00
Retrieve AST from R code 64.645921 ms (126.24447753824919) 68.74045054545455 ms (132.55959690808635) 0.94
Normalize R AST 92.4913375 ms (149.85132096524143) 96.19992009090909 ms (156.15063334620123) 0.96
Produce dataflow information 63.55928377272728 ms (161.70157094259665) 66.09041786363636 ms (169.92667998599904) 0.96
Total per-slice 1.9470626728825504 ms (1.4417350663168538) 1.8411702253695927 ms (1.267065280512554) 1.06
Static slicing 1.4784154988271623 ms (1.339962821900974) 1.3684034386686694 ms (1.1799623517395228) 1.08
Reconstruct code 0.45122614585978743 ms (0.22125903321476706) 0.4553098527401606 ms (0.2299566392692304) 0.99
failed to reconstruct/re-parse 0 # 0 # NaN
times hit threshold 0 # 0 # NaN
reduction (characters) 0.7329390759026896 # 0.7329390759026896 # 1
reduction (normalized tokens) 0.720988345209971 # 0.720988345209971 # 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"social-science" Benchmark Suite

Benchmark suite Current: a99a7f8 Previous: 243959c Ratio
Total per-file 7731.186864140001 ms (9394.119700045987) 5419.399718899999 ms (6111.491408384184) 1.43
Retrieve AST from R code 118.95161696 ms (104.04615561960837) 85.22318365999999 ms (79.41151212889127) 1.40
Normalize R AST 171.30431758 ms (111.94901195286876) 113.45254984 ms (69.72126242848063) 1.51
Produce dataflow information 256.21023602 ms (440.25643011203215) 164.38322226 ms (279.00889908327076) 1.56
Total per-slice 13.159301461900167 ms (22.812469361042186) 8.82827828085479 ms (14.575511768060265) 1.49
Static slicing 12.377299835164823 ms (22.67873525000376) 8.228727295296194 ms (14.45423896853327) 1.50
Reconstruct code 0.766629351319343 ms (0.5249688100272808) 0.5898725311439794 ms (0.30780610835907124) 1.30
failed to reconstruct/re-parse 9 # 9 # 1
times hit threshold 967 # 967 # 1
reduction (characters) 0.8987761232201357 # 0.8987761232201357 # 1
reduction (normalized tokens) 0.8582032343145828 # 0.8582032343145828 # 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.