This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
nock@9.0.6 breaks build 🚨 #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
nock just published its new version 9.0.6.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As nock is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 50 commits .
5856cde9.0.6: Fix for #8277197769Merge pull request #828 from node-nock/bug-827-matchStringOrRegexpf2ae8c1Bug #827 Defensive coding around target0fb8c3d9.0.5: Various bug fixes86babe8Merge pull request #822 from KingHenne/fix/isomorphic-fetch-basic-auth2318034Merge pull request #823 from KingHenne/fix/nyc-config58b04e3Merge pull request #769 from RubenVerborgh/fix-socket-this2ae0f25exclude test files from coverage reports7fbc2f9add text summary coverage reporter933cbadfix basicAuth/matchHeader interceptors with isomorphic-fetch26b2610add failing test for isomorphic-fetch and matchHeaderd8b6d62add failing test for isomorphic-fetch and basicAuth1d1cafcMerge pull request #821 from node-nock/chore-changelog-v9.0.4219241dUpdate changelog using "npm run changelog"8f20a6d9.0.4: Fix bug where only single set-cookie header would be returnedThere are 50 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.