fix(rpc/flipt): implement Requester for evaluation data snapshot #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George MacRorie <me@georgemac.com>
Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
force-pushed
the
gm/authz-eval-fixes
branch
from
f1c9864
to
8e642bb
Compare
Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
force-pushed
the
gm/authz-eval-fixes
branch
from
8e642bb
to
8b69df4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## authz-eval-fixes #3439 +/- ##
====================================================
+ Coverage 64.66% 64.69% +0.02%
====================================================
Files 174 174
Lines 13920 13919 -1
====================================================
+ Hits 9002 9005 +3
+ Misses 4227 4225 -2
+ Partials 691 689 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
markphelps
approved these changes
Sep 7, 2024
kodiakhq bot
added a commit
that referenced
this pull request
Sep 9, 2024
* fix: disable authz for all evaluation endpoints Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore: refactor authz test a bit Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore: add missing test Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * fix(rpc/flipt): implement Requester for evaluation data snapshot (#3439) * chore: fix lint error Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore: try to fix snapshot IT Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> --------- Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> Co-authored-by: George <me@georgemac.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposal for the open PR #3438
It changes the solution so that we actually request specific permissions when attempting to fetch evaluation snapshot data.
In order to enforce some level of authz and not leak entire namespace contents this way.