Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New features #13

wants to merge 1 commit into from

Conversation

rwdlnk
Copy link

@rwdlnk rwdlnk commented Aug 2, 2023

Dear Flexi Team:
Please consider pulling our document describing several new tutorial problems that we developed for Flexi. Please contact me at any time if you have comments or questions.

@flexi-framework
Copy link
Owner

Hi, many thanks for using and especially contributing to FLEXI!
We will have a look at you new testcases and come back to you if we have any questions (which we will probably have)!

@gahansen
Copy link

Hi, thank you for developing flexi, we have been able to get some very nice shock implosion results with it. We would like to contribute these for others, along with some code mods that allowed us to run them. How would be the best approach to do this? They are not really tutorials, they are more extended problems that may not have general interest. Would it be better to add these to the flexi-extensions repo instead of the tutorials? Please see this interesting implosion movie below:

implode_3.mp4

@flexi-framework
Copy link
Owner

Thank you for your contribution. While we like the results and documentation, we feel like size of the files is too large. Every user would need to wait for the complete download during cloning and we thus feel reluctant to merge the branch into our master.

At the same time, we would like your contribution to be easily accessible. We do not feel that documentation relevant to the main branch should be stored in the flexi-extension repository. We are currently in the process of internal re-organization on how we make such information publicly accessible in form of a flexi-testcase submodule. However, the process is still ongoing and we thus ask for your patience.

I will leave the PR open, so any new development can be reported here.

@gahansen
Copy link

Very good, we definitely understand the large file issue. I will reformulate this commit as hopr is used to generate the initial h5 files, if we leave those out it is a simple matter to use hopr to generate what is needed. I'll also rebase this fork to be off the tip of the current master branch. Thank you very much!

This commit adds several new problems to the Tutorials
directory in Flexi. These are Einfeldt (123), Hui (implode),
a multimaterial Sod test case (sod2), a Sedov blast wave
(sedov), and LeBlanc problems. Also included is a report that
discusses these problems and how to run them.

Co-authored-by: Rod Douglass <rwdlanm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants