-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes to DEP enrollment flow #20506
Conversation
Down migrations to be applied manually to dogfood and QA environments: ALTER TABLE mdm_idp_accounts DROP INDEX idx_mdm_idp_accounts_host_uuid;
ALTER TABLE mdm_idp_accounts DROP COLUMN host_uuid;
ALTER TABLE mdm_idp_accounts DROP COLUMN fleet_enroll_ref;
DELETE FROM migration_status_tables WHERE version_id IN(20240709175341, 20240710152744) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend revert LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should send a message to #help-engineering so that devs know that this change might break their local setups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good (assuming it's an exact revert).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20506 +/- ##
===========================================
- Coverage 55.12% 37.20% -17.93%
===========================================
Files 1426 1423 -3
Lines 134052 133761 -291
Branches 3218 3216 -2
===========================================
- Hits 73900 49764 -24136
- Misses 54125 79508 +25383
+ Partials 6027 4489 -1538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Reverts #20162 and #20355 per [QA findings](#19185 (comment))
Reverts #20162 and #20355 per QA findings