Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device user account creation during MDM IdP enrollment flow #20353

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

gillespi314
Copy link
Contributor

Note

This PR already merged in main, see #20162. This is against the release branch so it can be included in 4.54.0

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.54.0@14722e6). Learn more about missing BASE report.

Files Patch % Lines
frontend/utilities/endpoints.ts 0.00% 3 Missing ⚠️
frontend/services/entities/mdm.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.54.0   #20353   +/-   ##
======================================================
  Coverage                       ?   37.01%           
======================================================
  Files                          ?     1409           
  Lines                          ?   131890           
  Branches                       ?     3202           
======================================================
  Hits                           ?    48819           
  Misses                         ?    78684           
  Partials                       ?     4387           
Flag Coverage Δ
frontend 52.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gillespi314 gillespi314 merged commit 54311f3 into minor-fleet-v4.54.0 Jul 10, 2024
24 checks passed
@gillespi314 gillespi314 deleted the dep-enroll-ref-sg-2 branch July 10, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants