add a client for VPP calls #20243
add a client for VPP calls #20243
Conversation
server/mdm/apple/vpp/api.go
Outdated
| } | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return fmt.Errorf("calling Apple VPP endpoint failed with status %d", resp.StatusCode) |
There was a problem hiding this comment.
Not critical (especially since the Apple API appears to not use non-200 statuses 😢 ), but it's often useful for debugging purpose to add the response's body when the status is not success (ideally with a limited reader to prevent reading too much).
There was a problem hiding this comment.
great idea, thanks! I pushed f002dd4 addressing this.
Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
| } | ||
|
|
||
| func getBaseURL() string { | ||
| devURL := os.Getenv("FLEET_DEV_VPP_URL") |
server/mdm/apple/vpp/api.go
Outdated
| @@ -201,7 +201,14 @@ func do[T any](req *http.Request, token string, dest *T) error { | |||
| } | |||
|
|
|||
| if resp.StatusCode != http.StatusOK { | |||
| return fmt.Errorf("calling Apple VPP endpoint failed with status %d", resp.StatusCode) | |||
| // use an io.LimitedReader to read only a limited amount of the | |||
| // response body for logging purposes | |||
There was a problem hiding this comment.
Oh sorry, I didn't realize you already had the body read in full, in that case you could just check the len and limit it to 1024 bytes without using a reader. No big deal either way, though.
There was a problem hiding this comment.
I was wondering about that! sounds good! changes pushed
There was a problem hiding this comment.
LGTM, you should remove the comment above though ^
No description provided.