Add hostname to calendar event (maintenance window) bodies #20235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobshandling
requested review from
a team,
getvictor and
lucasmrod
as code owners
|
@lucasmrod I'd like to merge #20156 before this one |
lucasmrod
reviewed
Jul 8, 2024
| @@ -63,7 +63,8 @@ const CalendarEventPreviewModal = ({ | |||
| </div> | |||
| <div className={`${baseClass}__preview-info__text`}> | |||
| {orgName} reserved this time to make some changes to your work | |||
| computer. | |||
| computer ( | |||
| {showGenericPreview ? "ANNAS-DELL" : "Anna's MacBook Pro"}). | |||
There was a problem hiding this comment.
slightly different copy in the Figma for these two cases. Worth checking, @rachaelshaw was that intended?
There was a problem hiding this comment.
@jacobshandling I think we should actually keep it as "Anna's MacBook Pro" for everything. I had changed it in Figma to see how it would look with less pretty display names, but we should keep the more readable one for the preview! Sorry about that, I'll update the Figma.
@lucasmrod thanks for catching this!
lucasmrod
reviewed
Jul 8, 2024
lucasmrod
reviewed
Jul 8, 2024
jacobshandling
changed the title
jacobshandling
force-pushed
the
19281-add-hostname-to-maintenance-windows
branch
from
7c46a7f
to
b77693e
Compare
lucasmrod
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19281
changes/,