Improvements to logging in mdmproxy #20201
Conversation
zwass
commented
Jul 3, 2024
zwass
commented
- Add --debug flag to log Fleet requests and responses
- Add --log-skipped flag to disable logging most garbage requests by default
- Add --debug flag to log Fleet requests and responses - Add --log-skipped flag to disable logging most garbage requests by default
| strings.Contains(r.URL.Path, ".py") || | ||
| strings.Contains(r.URL.Path, "wp-") || | ||
| strings.Contains(r.URL.Path, "private") || | ||
| (r.URL.Path == "/" && r.Method == http.MethodPost) |
There was a problem hiding this comment.
if we find out this is not enough, we could also skip requests that don't contain Content-Type: application/x-apple-aspen-mdm-checkin or Content-Type: application/x-apple-aspen-mdm
| } | ||
| r.Body = io.NopCloser(bytes.NewReader(b)) | ||
|
|
||
| log.Println("Fleet response: ", string(b)) |
There was a problem hiding this comment.
should we print any extra information here? worried about the logs being harder to distinguish with multiple concurrent requests.
guessing this is just for staging testing with very few devices so not a concern, feel free to ignore if so
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20201 +/- ##
==========================================
- Coverage 62.65% 55.20% -7.45%
==========================================
Files 1405 1409 +4
Lines 131562 132012 +450
Branches 3216 3216
==========================================
- Hits 82429 72878 -9551
- Misses 42810 53198 +10388
+ Partials 6323 5936 -387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
