Frontend of iOS/iPadOS as platforms/labels #20157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
force-pushed
the
19962-ipados-ios-platforms
branch
from
ca58f31
to
63279f6
Compare
RachelElysia
changed the title
jacobshandling
previously requested changes
Jul 3, 2024
frontend/components/PlatformCompatibility/PlatformCompatibility.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/CustomSettings.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/EmptyTargetForm/EmptyTargetForm.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/TargetSection/TargetSection.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/PlatformTabs/PlatformTabs.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/PlatformTabs/PlatformTabs.tsx
Outdated
Show resolved
Hide resolved
RachelElysia
commented
Jul 3, 2024
RachelElysia
commented
Jul 3, 2024
RachelElysia
commented
Jul 3, 2024
...eControlsPage/OSSettings/cards/CustomSettings/components/ProfileListItem/ProfileListItem.tsx
Outdated
Show resolved
Hide resolved
RachelElysia
commented
Jul 3, 2024
frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/TeamDetailsWrapper.tsx
Show resolved
Hide resolved
RachelElysia
force-pushed
the
19962-ipados-ios-platforms
branch
from
393681c
to
0f7907a
Compare
jacobshandling
approved these changes
Jul 5, 2024
| @@ -45,10 +45,16 @@ const HostsSummary = ({ | |||
| opacity = isLoadingHostsSummary ? { opacity: 0.4 } : { opacity: 1 }; | |||
| } | |||
|
|
|||
| const getBuiltinLabelId = useCallback( | |||
| @@ -22,12 +22,12 @@ const DISPLAY_ORDER = [ | |||
| "Windows", | |||
| "Linux", | |||
| "ChromeOS", | |||
| ] as SupportedDisplayPlatform[]; | |||
| ] as QueryableDisplayPlatform[]; | |||
There was a problem hiding this comment.
For speed this can be on another iteration but can we still improve the typing on line 14?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Frontend of story #19962
Description
Lots of page changes
Screenshots and screen recordings
Early recording with ~1/2 the changes in
https://www.loom.com/share/e9d8c4c934634f4abfe04369ca35dd36?sid=4c1527ad-a923-4183-b1fe-df34890be6c6
Updates to the OS Updates page
Everything working on @lucasmrod 's integration test 7/3/24 1:15 EST
https://www.loom.com/share/e32739f113fe4a0eb275e307578ff367?sid=4f2e601e-de7a-4614-88d1-dd5495a4bed7
Checklist for submitter
If some of the following don't apply, delete the relevant line.
On backend ticket