Run GitOps in dry-mode only on pull request #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@spokanemac please review this PR if you have time |
noahtalerman
reviewed
May 7, 2024
| workflow_dispatch: # allows manual triggering | ||
|
|
||
| # Prevent concurrent runs of this workflow. |
There was a problem hiding this comment.
Hey @getvictor, does this mean that if two contributor open a PR around the same time, only one contributor will get feedback from the dry run? (errors)
Sorry for the delayed response.
There was a problem hiding this comment.
No, it should wait for the first dry run to finish before starting the other one. So, both contributors should get feedback.
This concurrency constraint was meant to prevent multiple real runs from running in parallel.
noahtalerman
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fleetdm/fleet#17687
Run GitOps in dry-mode only on pull request