Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove flutter_map text attribution when showFlutterMapAttribution is false #1712

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: remove flutter_map text attribution when showFlutterMapAttribution is false #1712

merged 1 commit into from
Oct 31, 2023

Conversation

leiflinse-trivector
Copy link
Contributor

When showFlutterMapAttribution is false, there is still a text "Made with 'flutter_map' that is displayed. This PR removes it.

bild

TesteurManiak
TesteurManiak approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JaffaKetchup
JaffaKetchup approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks!
This likely won't be released for a little while.

@JaffaKetchup JaffaKetchup changed the title fix: do not show Made with 'flutter_map' when showFlutterMapAttribution is false fix: do not show flutter_map text attribution when showFlutterMapAttribution is false Oct 31, 2023
@JaffaKetchup JaffaKetchup changed the title fix: do not show flutter_map text attribution when showFlutterMapAttribution is false fix: remove flutter_map text attribution when showFlutterMapAttribution is false Oct 31, 2023
@JaffaKetchup JaffaKetchup merged commit 04e54ae into fleaflet:master Oct 31, 2023
6 checks passed
@josxha josxha added the bug This issue reports broken functionality or another error label Nov 28, 2023
josxha pushed a commit that referenced this pull request Nov 28, 2023
@leiflinse-trivector @josxha
fix: remove flutter_map text attribution when `showFlutterMapAttribut…
0f5c589 
…ion` is `false` (#1712)
@josxha josxha added this to the v6.1 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TesteurManiak TesteurManiak TesteurManiak approved these changes

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
bug This issue reports broken functionality or another error
Projects
None yet
Milestone
v6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@leiflinse-trivector @TesteurManiak @JaffaKetchup @josxha