Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple bugs when neither wmsOptions nor urlTemplate were provided #1701

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: multiple bugs when neither wmsOptions nor urlTemplate were provided #1701

merged 1 commit into from
Oct 23, 2023

Conversation

JaffaKetchup
Copy link
Member

@JaffaKetchup JaffaKetchup commented Oct 23, 2023 •
edited
Loading

  • Fixed bug where not providing either wmsOptions nor urlTemplate caused a null exception in getTileUrl
  • Fixed bug where not providing either wmsOptions nor urlTemplate caused a null exception when retinaMode was true
  • Added in-code documentation for TileProvider authors

@JaffaKetchup
Fixed bug where not providing either wmsOptions nor urlTemplate c…
58fc07f 
…aused a null exception in `getTileUrl`

Fixed bug where not providing either `wmsOptions` nor `urlTemplate` caused a null exception when `retinaMode` was `true`
Added in-code documentation for `TileProvider` authors
@JaffaKetchup JaffaKetchup merged commit ea79e2a into master Oct 23, 2023
7 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-null-url-template-bugs branch October 23, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TesteurManiak TesteurManiak TesteurManiak approved these changes

@ibrierley ibrierley Awaiting requested review from ibrierley

@mootw mootw Awaiting requested review from mootw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaffaKetchup @TesteurManiak