Support current_folder with FileChooser.OpenFile #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the OpenFile method in the file chooser portal supports the current_folder option, we should perform the same reverse lookup as the SaveFile method, to present the location on the host when given a location inside the document portal storage.
We've been calling complete_open_file() for both save methods since the code was first ported to gdbus-codegen. Luckily, the signature is currently the same on every method.
The byte arrays are expected to be terminated by a nul byte, and they express a path in the same encoding as the file system.
Document its behaviour in the same way we document it for the SaveFile method.
The current_folder option is passed to the OpenFile invocation.
4 tasks
GeorgesStavracas
approved these changes
Jun 29, 2023
|
+1 from me |
btzy
added a commit
to btzy/nativefiledialog-extended
that referenced
this pull request
Jun 30, 2023
…ickFolder (#108) This has been implemented in flatpak/xdg-desktop-portal#1045.
|
Thank you so much to everyone who worked on this! |
sophie-h
added a commit
to sophie-h/ashpd
that referenced
this pull request
Nov 10, 2023
sophie-h
added a commit
to sophie-h/ashpd
that referenced
this pull request
Nov 11, 2023
bilelmoussaoui
pushed a commit
to bilelmoussaoui/ashpd
that referenced
this pull request
Dec 19, 2023
bilelmoussaoui
pushed a commit
to bilelmoussaoui/ashpd
that referenced
this pull request
Jan 6, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 14, 2024
This change adds support for opening a file dialog in the current folder in the SelectFileDialogLinuxPortal. Support for this feature was added in xdg-desktop-portal via flatpak/xdg-desktop-portal#1045. Electron makes use of this feature and this allows us to remove a patch to enable this functionality. Change-Id: I3f95bdff0c6a834f965ed3c153eb1a99902f61bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786982 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1341908}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796
Supercedes: #874