Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nv-codec-headers to 12.1.14.0 #352

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

Bleuzen
Copy link
Contributor

@Bleuzen Bleuzen commented Mar 15, 2024

This enables AV1 hardware encoding

@flathubbot
Copy link
Contributor

Started test build 107279

@flathubbot
Copy link
Contributor

Build 107279 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90095/org.kde.kdenlive.flatpakref

@flathubbot
Copy link
Contributor

Started test build 107794

@flathubbot
Copy link
Contributor

Build 107794 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90610/org.kde.kdenlive.flatpakref

@flathubbot
Copy link
Contributor

Started test build 107805

@flathubbot
Copy link
Contributor

Build 107805 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90621/org.kde.kdenlive.flatpakref

@travier
Copy link
Member

travier commented Mar 18, 2024

I've merged a few updates alongside this one. Can someone confirms that this builds works? Thanks

@travier
Copy link
Member

travier commented Mar 18, 2024

Hum, we stop this update in #259 so we might not be able to do it.

@Bleuzen
Copy link
Contributor Author

Bleuzen commented Mar 20, 2024

Hum, we stop this update in #259 so we might not be able to do it.

I see so we need to decide if we favor supporting new features vs older GPUs. Given that even the most recent GPUs we would drop support for by this update are 11 years old already I question how important it is prevent progress for those

According to latest Steam hardware survey there is only one GPU still listed from the dropped ones which is still used by 0.38% of users - trending downwards

Meanwhile GPUs supporting AV1 which would benefit from this update are used by 12.3% (summed) of users

So while it is always sad dropping support for something - at this point I think it makes sense to update because it seems to affect a lot more people

but keep in mind that these numbers are taken from Steam and the Steam users are not exactly the same group as Kdenlive users - so it is not perfect but could help with the decision

CC @guihkx

@guihkx
Copy link
Contributor

guihkx commented Mar 20, 2024

Thanks for pinging me, @Bleuzen.

I'm just an occasional contributor, though, so my opinion might not be that important here.

Anyway, I do still have a GTX 660, and this change will ultimately prevent me from using H.264 NVENC encoding, because the 12.x branch doesn't work with my GPU.

While I have my doubts about how ubiquitous the AV1 codec really is at the moment (especially when compared to H.264), I do understand and support the need of moving forward to newer codecs, and it'd be unreasonable to stay on the 11.x branch, forever.

All of that to say that I won't personally oppose or approve this PR, and I hope maintainers can use their best judgment.

@travier
Copy link
Member

travier commented Mar 25, 2024

Appart from publishing two distinct Flatpaks, which is not ideal, we could also push this update to the main channel and keep the older libraries in the Beta remote to keep the Flatpak available for a while for users of old GPUs.

@guihkx
Copy link
Contributor

guihkx commented Mar 25, 2024

That's a good solution, too! Unless it becomes a maintenance burden for you guys, of course.

By the way, this is not really a problem for me, because I know how to make my own build.

flathubbot and others added 2 commits March 30, 2024 13:58
Update pycparser-2.21-py2.py3-none-any.whl to 2.22
Update intel-onevpl-24.1.5.tar.gz to 24.2.0
Update libmediainfo_24.01.tar.xz to 24.03
Update mediainfo_24.01.1.tar.xz to 24.03
@travier
Copy link
Member

travier commented Mar 31, 2024

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.kde.kdenlive.

@flathubbot
Copy link
Contributor

Started test build 111134

travier added a commit that referenced this pull request Mar 31, 2024
@travier
Copy link
Member

travier commented Mar 31, 2024

I've updated this branch with a README with a note and more deps updates.

@Bleuzen Could you test the build here? Thanks

I've made #360 to update the Beta version to the same content minus this update.

@guihkx Could you test the build there? Thanks

@flathubbot
Copy link
Contributor

Started test build 111137

@flathubbot
Copy link
Contributor

Build 111134 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93949/org.kde.kdenlive.flatpakref

@flathubbot
Copy link
Contributor

Build 111137 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93952/org.kde.kdenlive.flatpakref

@Bleuzen
Copy link
Contributor Author

Bleuzen commented Mar 31, 2024

@travier build 111137 works here

@travier
Copy link
Member

travier commented Apr 1, 2024

Thanks!

@travier travier merged commit b0e8f6c into flathub:master Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants