-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plume prune enhancement #343
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c8e55e0
cmd/plume/prune: show region name in log output
jepio b2f2cfb
update aws-sdk to v1.44.46
jepio af74535
cmd/plume/prune: support keeping last N images
jepio 3efabb9
cmd/plume/prune: support soft-deleting images
jepio c1654b2
cmd/plume/prune: print ami-id when image is marked for deletion
jepio 6896af0
cmd/plume/prune: print stats when deleting images
jepio fe7b514
cmd/plume/prune: support checking if image was recently used before d…
jepio e583261
cmd/plume/prune: use camelCase for variables
jepio 54246f2
cmd/plume/prune: validate parameters and check for '> 0'
jepio d2b2000
cmd/plume/prune: add cli flag to configure lastLaunchedTime threshold
jepio d698ec3
cmd/plume/prune: make deleteStats struct members internal
jepio 15c9533
changelog: add entry for plume prune changes
jepio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the helper:
Even if the default value is 0, we could add an extra condition like you're doing later:
EDIT: we could even group the two statements:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather keep the if-blocks separate so that we can report a clear error messages to users. But you made me realize I need at least one more check:
if !checkLastLaunched && daysLastLaunched > 0
so that we tell users that the option will be ignored.