kola/misc/raid: change CLC to raw ignition config #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`size` has been deprecated to `sizeMiB` from `ignition-2.3` and this parameter is not translatable. See the discussion in here: coreos/ign-converter#29 Since CLC is converted to `ignition-2.2` we can't rely on this to pass the config so we directly use raw ignition 2.3.0 to provision the instance. This test only runs on `qemu` so there is no side effect to pass from `clc` to `ignition`. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
krnowak
reviewed
Sep 24, 2021
| { | ||
| "label": "root1", | ||
| "number": 1, | ||
| "sizeMiB": 256, |
There was a problem hiding this comment.
I see that we were lucky using 256MiB for size before, so you didn't need to convert that from sectors to bytes.
krnowak
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizehas been deprecated tosizeMiBfromignition-2.3and thisparameter is not translatable. See the discussion in here: coreos/ign-converter#29
Since CLC is converted to
ignition-2.2we can't rely on this to passthe config so we directly use raw ignition 2.3.0 to provision the
instance.
This test only runs on
qemuso there is no side effect to pass fromclctoignition.Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
Testing done
Tested against: