Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola/docker: add selinux test #177

Merged
merged 1 commit into from
Aug 5, 2021
Merged

kola/docker: add selinux test #177

merged 1 commit into from
Aug 5, 2021

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Jun 4, 2021 •
edited
Loading

we create a simple scenario where the user would run a docker container
with a shared volume within SELinux context.

How to use

⚠️ can't be run with current Flatcar release as it needs SELinux updates

Testing done

sudo ./bin/kola run -b cl -p qemu --qemu-image flatcar_production_qemu_image.img docker.selinux

closes flatcar/Flatcar#304

This was referenced Jun 4, 2021
Merged
Merged
@tormath1 tormath1 force-pushed the tormath1/selinux branch 3 times, most recently from b70ba18 to 3de0a45 Compare June 9, 2021 13:39
@tormath1 tormath1 changed the title [wip] kola/docker: add selinux test kola/docker: add selinux test Jun 11, 2021
@tormath1 tormath1 self-assigned this Jun 11, 2021
@tormath1 tormath1 requested a review from a team June 11, 2021 09:49
@tormath1 tormath1 marked this pull request as ready for review June 11, 2021 09:50
@tormath1 tormath1 force-pushed the tormath1/selinux branch 2 times, most recently from 2dd9322 to cd87709 Compare August 5, 2021 07:59
@tormath1
Copy link
Contributor Author

tormath1 commented Aug 5, 2021

@kinvolk/flatcar-maintainers if you have a few minutes to review this - it includes a basic SELinux test for Docker. :) I force pushed to include beta to supported versions.

jepio
jepio approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it be possible to directly skip on arm64 as long as we don't have selinux there?

@tormath1
Copy link
Contributor Author

tormath1 commented Aug 5, 2021

@jepio thanks for the review ! arm64 is now excluded from the test. Let's wait for the CI, then squash and merge.

kola/docker: add selinux test
64dd9df 
we create a simple scenerio where the user would run a docker container
with a shared volume within SELinux context

Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
@tormath1 tormath1 merged commit e4a6261 into flatcar-master Aug 5, 2021
@tormath1 tormath1 deleted the tormath1/selinux branch August 5, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepio jepio jepio approved these changes

Assignees

@tormath1 tormath1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add kola tests to verify SELinux functionality
2 participants
@tormath1 @jepio