kola: add raid0 tests for root and data devices #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/kola-raid0
branch
from
aabada2
to
b748b0c
Compare
|
opened "Dec 13, 2019" ahah - @dongsupark are you still interested by contributing to this PR ? I think it would be nice to have this new tests ! |
|
@tormath1 Thanks for the reminder. 👍 |
dongsupark
force-pushed
the
dongsu/kola-raid0
branch
from
b748b0c
to
b509b5f
Compare
|
Rebased. Locally tested. |
tormath1
reviewed
Oct 20, 2021
To be able to parametrize raid levels for RAID tests, we should create a helper function `ExecTemplate()` that reads template and parses it into an actual output string. Also make the existing root raid test use `ExecTemplate()`.
The existing data raid test should also make use of `ExecTemplate()` helper. Convert the input config for raid1 data also into the ignition format, to make it consistent with the raid1 root config.
Instead of manually checking if a type is raid1, we should create a helper `isValidRaidType()` that checks if it is one of the pre-defined raid types.
dongsupark
force-pushed
the
dongsu/kola-raid0
branch
from
b509b5f
to
2e4481c
Compare
tormath1
reviewed
Oct 20, 2021
We should test root & data devices, not only with raid1 but also with raid0, to catch issues with raid0 devices. To reduce amount of code, we iterate through the map of raidTypes.
Add an entry for new kola raid0 tests. Fix a typo.
dongsupark
force-pushed
the
dongsu/kola-raid0
branch
from
2e4481c
to
95aa844
Compare
|
Done, added changelog. |
tormath1
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should test root and data devices not only with raid1 but also with raid0, to catch issues with raid0 devices.
To be able to parametrize raid levels for RAID tests, we should create a helper function
ExecTemplate()that reads template and parses it into an actual output string. Also make the existing raid tests useExecTemplate().