Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the bribes #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Raise the bribes #1

wants to merge 2 commits into from

Conversation

BreezeRo
Copy link

@BreezeRo BreezeRo commented May 2, 2023

I propose changing the default bribe to 99% to give new operators a better chance at replicating some of this live and understanding how it operates out of the box.

I propose changing the default bribe to 99% to give new operators a better chance at replicating some of this live and understanding how it operates out of the box.
@bertmiller
Copy link
Member

Sorry what? I don't understand how that achieves what you're saying 😆

@BreezeRo
Copy link
Author

BreezeRo commented May 2, 2023

By setting the starting bribe to 50% users are currently more likely to assume that they will need to bid higher than 50% to be competitive which will increase the chances of new users not succeeding as other existing operators push the bribes near 100. I think if the bribe is set to 99% by default new comers will be on nearly same playing field as existing operators running this repo out of the box

@itasli
Copy link

itasli commented May 3, 2023

Setting 99% on the readme file won't change the config file though

raise the bribes
@BreezeRo
Copy link
Author

BreezeRo commented May 3, 2023

Updated sir

@j6i
Copy link

j6i commented May 7, 2023

percentageToKeep is this from the perspective of the searcher or the validator? If it's the searcher, I think you just set it to give 1% to the validator.

@BreezeRo
Copy link
Author

BreezeRo commented May 7, 2023

percentageToKeep is this from the perspective of the searcher or the validator? If it's the searcher, I think you just set it to give 1% to the validator.

The percentageToKeep variable is passed to the executeArbitrage method but that method parameter is titled percentageToPayToCoinbase

uint profitToCoinbase = profit.mul(percentageToPayToCoinbase).div(100);

From my understanding percentageToKeep is the percentage the miner keeps, if this is case the reason it's not a problem out of the box is because if the bribe is 50% there will never be a discrepancy. Perhaps it should be renamed

@BreezeRo BreezeRo changed the title Update readme.md Raise the bribes May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants