Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inferno dependency to 0.11.19 #296

Conversation

SergejIsbrecht
Copy link

Update to latest inferno version to include 0.11.12 in order to increase flamegraph.svg rendering performance

jonhoo/inferno#262

@djc
Copy link
Contributor

djc commented Dec 29, 2023

Since this is a semver-compatible version bump, there really is no need to change Cargo.toml. Also, using cargo install to install the flamegraph/cargo-flamegraph binaries off of crates.io should already be using latest inferno 0.11.x without this change, so I don't think this a very useful change.

@SergejIsbrecht
Copy link
Author

SergejIsbrecht commented Dec 30, 2023

@djc , I have to cross compile for aarch64, therefore I can not use cargo install

Edit:
It seems I can add --target, which should do the job. I will verify whether cargo install with --target works as you described.

Edit:
When using cargo install flamegraph -v it seems inferno indeed is used in version 0.11.19
Compiling inferno v0.11.19

Sorry for the inconvenience.

@SergejIsbrecht SergejIsbrecht deleted the for/main/sergej/update_inferno branch December 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants