Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace CurvedParticle inheritance with Particle in ScaledParticle #3221

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

duck-dev-go
Copy link
Contributor

feat: Replace CurvedParticle inheritance with Paricle in ScaledParticle

This PR removed the CurvedParticle inheritance from the ScaledParticle, as the scale did not change over time which also ensures backwardwards compatibility as the Curve essentially did nothing.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon spydon changed the title Replace CurvedParticle inheritance with Particle in ScaledParticle fix: Replace CurvedParticle inheritance with Particle in ScaledParticle Jul 11, 2024
@spydon spydon enabled auto-merge (squash) July 11, 2024 20:21
@spydon spydon merged commit 8cd054d into flame-engine:main Jul 11, 2024
8 of 9 checks passed
@duck-dev-go duck-dev-go deleted the remove-curved-inheritance branch July 11, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants