feat(flame_3d): Make shader api more useful #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2024
luanpotter
added a commit
that referenced
this pull request
Apr 27, 2024
Fix minor nits on flame_3d, namely: * fix wrong bash command on the readme file * add missing git ignore to the example This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
added a commit
that referenced
this pull request
Apr 27, 2024
Add helpful extension functions to Vector classes, including tests. This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
force-pushed
the
feat(flame_3d)-make-shader-api-more-useful
branch
from
4e9f73c
to
82083c3
Compare
6 tasks
|
I can't wait for this |
luanpotter
force-pushed
the
feat(flame_3d)-make-shader-api-more-useful
branch
from
085f037
to
db1465f
Compare
…3179) Cleanup lighting code and remove unused Standard Material.
luanpotter
force-pushed
the
feat(flame_3d)-make-shader-api-more-useful
branch
from
db1465f
to
a15f851
Compare
Implement a basic light abstraction. Still only supports one light for now, and no parameters other than its position. Note: I will fix the 0-lights case when I add support for multiple lights. A few complications arose that led me to revamp our component system a bit. Basically splitting the `Component3D` class into a more fundamental version of itself that only includes the 3D positioning stuff, and none of the rendering stuff, and what used to be `Component3D` becomes `Object3D` (I am not sold on the names, feel free to suggest replacements). I also added a `Group3D` class to allow for people to create groups of components without carrying the rendering code. Of course you can still add children to Object3D as well. I am open to removing it and just making `Component3D` concrete instead. The image below explains the new structure:  --- The difference between the 3 "light" classes: * `LightComponent` → interacts with FCS. is Component3D, thus carries the position * `LightSource` → describes the light in abstract terms (minus position). used both by `LightComponent` and `Light` * `Light` → base description of a Light as a Resource. FCS agnostic. includes properties (source) + position Again, I am open to any renames. --- ## FAQ #### why separate component3d and object 3d? not really needed but I didn't want light component to "carry" the rendering code that is not used. that also makes the distinction more clear as objects are completely different than lights. that way we don't have to have a definition of "non-light objects/components" #### ~why do we need group3d?~ i removed group3d! ~again not really needed, you can add children to objects, but if you want a pure container (no rendering), this would make more semantic sense. other options would be to not have anything (tell people to group things using object3d) or make component3d concrete (tell people to use that). having group3d consolidates the separation of light as its own thing.~ #### why some classes end in 3D and some classes end in Component [answer](https://martinfowler.com/bliki/TwoHardThings.html) (please help)
luanpotter
added a commit
that referenced
this pull request
Jul 23, 2024
Fix minor nits on flame_3d, namely: * fix wrong bash command on the readme file * add missing git ignore to the example This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
added a commit
that referenced
this pull request
Jul 23, 2024
Add helpful extension functions to Vector classes, including tests. This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
added a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Luan Nico <luanpotter27@gmail.com>
luanpotter
added a commit
that referenced
this pull request
Jul 27, 2024
Fix minor nits on flame_3d, namely: * fix wrong bash command on the readme file * add missing git ignore to the example This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
added a commit
that referenced
this pull request
Jul 27, 2024
Add helpful extension functions to Vector classes, including tests. This was extracted directly from @wolfenrain 's [bigger PR](#3085), making it easier to merge later.
luanpotter
added a commit
that referenced
this pull request
Jul 27, 2024
Co-authored-by: Luan Nico <luanpotter27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BIG WIP
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues