Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs and comments (flame_3d) #3057

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented Feb 28, 2024

Description

@luanpotter took over this PR!
While this doesn't fix the build yet, we can merge the nice improvements on comments and docs to get it closer to being green.

Update docs and comments, fixing lint issues as well.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@wolfenrain wolfenrain changed the title ci: unbreak the pipeline ci: Unbreak the pipeline Feb 28, 2024
@wolfenrain wolfenrain changed the base branch from main to flame_3d March 2, 2024 08:24
@luanpotter luanpotter changed the title ci: Unbreak the pipeline docs: Update docs and comments (flame_3d) Jul 24, 2024
@luanpotter luanpotter marked this pull request as ready for review July 24, 2024 12:48
@luanpotter luanpotter requested a review from spydon July 24, 2024 12:48
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit, other than that it looks good!

packages/flame_3d/CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@luanpotter luanpotter merged commit 1c5f235 into flame_3d Jul 24, 2024
5 of 8 checks passed
@luanpotter luanpotter deleted the ci-unbreak-the-pipeline branch July 24, 2024 15:53
luanpotter added a commit that referenced this pull request Jul 27, 2024
Update docs and comments, fixing lint issues as well.

---------

Co-authored-by: Luan Nico <luanpotter27@gmail.com>
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants