Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BoundedPositionBehavior can follow after reached bounds #1903

Closed
wants to merge 2 commits into from

Conversation

doowonee
Copy link

Description

My english is bad..

I change BoundedPositionBehavior behavior

Before

before.mp4

As you see, camera does not follow when it meets bound untill target object come back.

After

after.mp4

Now camera can follow event it meets bound and target object moves different axis of bounds

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Actually I found this on discussions

@doowonee doowonee marked this pull request as draft September 13, 2022 13:05
Copy link
Contributor

@st-pasha st-pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach would not work for non-rectangular shape of the camera bounds.

@doowonee
Copy link
Author

Oh right my bad..

The bound was a shape not a rectangle I'm sorry.

@doowonee doowonee closed this Sep 14, 2022
@st-pasha
Copy link
Contributor

No worries, I created an issue #1905, so we'd eventually get to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants