feat(effects): Added SpeedEffectController #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Dec 21, 2021
packages/flame/lib/src/effects/controllers/effect_controller.dart
Outdated
Show resolved
Hide resolved
spydon
requested review from
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
spydon
approved these changes
Dec 23, 2021
luanpotter
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
SpeedEffectController-- new kind of effect controller that can be used to create effects that proceed with a predefined speed. In addition, the factory constructorEffectController()now has 2 more parametersspeedandreverseSpeedfor easier creation of speed-based effects. The argumentdurationis now optional.The base
EffectControllerclass now hasonMount()callback, which is invoked when the effect controller is attached to anEffect.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Closes #1239