Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Riverpod support #2353

Closed
devberkay opened this issue Feb 20, 2023 · 8 comments
Closed

Official Riverpod support #2353

devberkay opened this issue Feb 20, 2023 · 8 comments

Comments

@devberkay
Copy link

Problem to solve

Games need complex state management solutions and Riverpod is the core dependency for many flutter developers like me.

Proposal

It would be amazing if we could see a collabaration in the future as it was done with flame_bloc package.

More information

@rrousselGit

@spydon
Copy link
Member

spydon commented Feb 20, 2023

Lucky for you there is already a package for this, which we soon will be reviewing and bringing in to the monorepo.
https://github.com/markvideon/flame_riverpod
https://pub.dev/packages/flame_riverpod

@spydon
Copy link
Member

spydon commented Feb 20, 2023

@markvideon do you know when you'll put up a PR for this? :)

@rrousselGit
Copy link

Making an official Riverpod implementation involves more work.

As is, it's not going to work with any tools like riverpod_lint & upcoming.

@spydon
Copy link
Member

spydon commented Feb 20, 2023

Making an official Riverpod implementation involves more work.

As is, it's not going to work with any tools like riverpod_lint & upcoming.

Well depends on what is meant with official here I guess, if they mean an official bridge package from the Flame side (like flame_bloc) or if they mean official from the Riverpod side.

@rrousselGit
Copy link

rrousselGit commented Feb 20, 2023

I assume it should be official for both sides at the same time. Otherwise it's not truly official right? :)
Where the project sits doesn't really matter. I'm fine with it being in the flame repository.

But it should be compatible with riverpod_lint, which is a core Riverpod package. Nothing blocking, but I'm sure it'd be inconvenient for Riverpod users if flame's consumer broke the various refactors & lints

@spydon
Copy link
Member

spydon commented Feb 20, 2023

I assume it should be official for both sides at the same time. Otherwise it's not truly official right? :)

True true. :)

But it should be compatible with riverpod_lint, which is a core Riverpod package. Nothing blocking, but I'm sure it'd be inconvenient for Riverpod users if flame's consumer broke the various refactors & lints

Alright, let's create an issue for that once the initial version is merged into the monorepo.
I ran the linter on the the example that was provided in the repository and there were no warnings reported in there, but you're probably right that refactors wouldn't work like they should.

@markvideon
Copy link
Contributor

@markvideon do you know when you'll put up a PR for this? :)

I'll try to get to it this week

spydon pushed a commit that referenced this issue Dec 1, 2023
Previously discussed with @spydon and referenced in issue #2353,
flame_riverpod is to be integrated into the monorepo.
@markvideon
Copy link
Contributor

@spydon can probably close this one?

@spydon spydon closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants