feat: ✨ initial implementation of JsonlCorpora and Datasets #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.pre-commit-config.yaml
Outdated
| rev: stable | ||
| hooks: | ||
| - id: black | ||
| language_version: python3.6 | ||
| - repo: https://github.com/pycqa/isort | ||
| rev: stable | ||
| rev: 5.10.1 | ||
| hooks: | ||
| - id: isort | ||
| name: isort (python) |
There was a problem hiding this comment.
nice to have a new line at end of fine so GitHub doesn't complain
Suggested change
| name: isort (python) | |
| name: isort (python) | |
.pre-commit-config.yaml
Outdated
Comment on lines
5
to
6
| - id: black | ||
| language_version: python3.6 |
There was a problem hiding this comment.
bad indentation. Note that these changes to this file are already proposed in #2651
Suggested change
| - id: black | |
| language_version: python3.6 | |
| - id: black | |
| language_version: python3.6 |
flair/datasets/sequence_labeling.py
Outdated
| # Add IOB tags | ||
| prefix = "B" | ||
| for token in sentence[start_idx : end_idx + 1]: | ||
| token.add_label("ner", f"{prefix}-{label}") |
There was a problem hiding this comment.
Why does this code assume that label_type is always ner? What is you trying to do PoS tagging or any other type of labelling?
There was a problem hiding this comment.
Oh, my bad!
I forgot to parameterize this. I will change it ASAP.
There was a problem hiding this comment.
I added label_type as a parameter with the default value ner.
|
@AnotherStranger thanks a lot for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an initial implementation for JSONL datasets using doccanos JSONL format.
I tried to replicate the behavior of the existing ColumnCorpus.
I'd love to get feedback on the implementation.
Closes #2605