Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Implement chrdev #96

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Implement chrdev #96

merged 1 commit into from
Jul 12, 2019

Conversation

alex
Copy link
Member

@alex alex commented Jun 19, 2019

No description provided.

@alex alex force-pushed the chrdev branch 15 times, most recently from 4795eb3 to 663cf82 Compare June 20, 2019 12:48
@alex
Copy link
Member Author

alex commented Jun 21, 2019

@geofft Ok. So here are the open questions:

  • FileOperations probably needs an fn open(<something) -> Self right? Should our function pointer then Box<Self> and stick it in file->private? Is file->private ever anything besides a pointer? Do users ever need more control than that?
  • Every method on FileOperations can be called concurrently with one another, right? We probably need to make all the methods take &self, requires FileOperations to be Sync, and tell people to put locks around their shit if they want to do stuff, right? We shouldn't provide locking for them, I don't think?
  • Do you have any objections to the API I've sketched out in the PR? Just making the vtable explicit seemed like the easiest thing.

@alex alex force-pushed the chrdev branch 11 times, most recently from f3cf59d to 1ddf8b3 Compare June 21, 2019 20:43
@alex
Copy link
Member Author

alex commented Jun 21, 2019

Oh... also the lifetimes around DeviceNumberRegion and DeviceRegistration are impossible.

@alex alex force-pushed the chrdev branch 2 times, most recently from d9acbbf to 0aa06cb Compare June 22, 2019 14:40
@alex
Copy link
Member Author

alex commented Jul 7, 2019

This is now rebased on top of #107, that should be reviewed/merged first.

@alex alex force-pushed the chrdev branch 2 times, most recently from 4a5bdc0 to 7776918 Compare July 7, 2019 19:33
@alex alex changed the title Initial hacking towards tests for chrdev, plus some random code to implement it Implement chrdev Jul 10, 2019
src/chrdev.rs Show resolved Hide resolved
src/chrdev.rs Outdated Show resolved Hide resolved
src/chrdev.rs Show resolved Hide resolved
src/chrdev.rs Outdated Show resolved Hide resolved
@alex alex force-pushed the chrdev branch 3 times, most recently from ffb26a0 to 6d10d76 Compare July 11, 2019 12:52
@geofft geofft merged commit efdb5e8 into master Jul 12, 2019
@alex alex deleted the chrdev branch July 12, 2019 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants