button sounds #236
button sounds #236
Conversation
|
I believe it is done. |
|
They sound ok to me. I would (personal taste) increase the volume a bit, but it's fine as now. When I click on "Start Game", I don't hear anything; I don't know if this is intended or not (also on Quit, but that's more likely to be intended). |
The quit thing can be easily fixed. Just don't close the game immediately. About the start button, it should just play a |
|
@64kramsystem About the quit game button... To make this work, it would be necessary to OR put audio code in the "exit" button code OR put "exit" button code in the audio code, and i don't think it would be that cool. |
removing random println button clicking sounds update cargo fmt & cargo clippy cargo fmt new audio at start game button
DRuppFv
force-pushed
the
button_sound
branch
from
5a8d72e
to
9ed44ec
Compare
Ah! I've noticed it. I'm neutral to whatever is used, however, it's hard to notice. |
It's a "normal" sound of "Start Game" button, you can see something like this in a lot of games like Punchy, but you are right. It would be better if we had a loading screen. And i just put a new one btw |
|
bors merge |
|
Build succeeded:
|
Note: I removed a lot of code that was not done
Just need help with playing the audio, the audio files are in the PR