Add items picking logic #126
Conversation
64kramsystem
changed the title
64kramsystem
force-pushed
the
add_items_picking_2
branch
from
d7cdbbf
to
412bf2f
Compare
|
Rebased. |
src/item.rs
Outdated
| #[derive(Component)] | ||
| pub struct Item; | ||
|
|
||
| #[derive(Component)] | ||
| pub struct CarriedBy(pub Entity); | ||
|
|
||
| /// Represents an item, that is either on the map (waiting to be picked up), or carried. | ||
| /// If an item is on the map, it has a TransformBundle; if it's carried, it instead has a | ||
| /// CarriedBy. |
There was a problem hiding this comment.
Im wondering if instead of ridding the item of its TransformBundle we might consider pushing it as a child of the Fighter who picks it up?
There was a problem hiding this comment.
It might be awkward at first before we figure out how to integrate it with animations/what offset/rotation and whatnot it should have, but for now we could always toggle the visibility of the item off when its picked up as well.
There was a problem hiding this comment.
There you go! Done. It actually made the code a little bit simpler 😄
There was a problem hiding this comment.
Ok. There have been several conflicts, that I had to fix. I've verified the rebase, hopefully, there have been no subtle breakages 😅.
…r certain conditions
…cking functionality
64kramsystem
force-pushed
the
add_items_picking_2
branch
2 times, most recently
from
78e2c6c
to
43c2f3f
Compare
| if player_item_distance <= PICK_ITEM_RADIUS { | ||
| commands.entity(item_id).remove_bundle::<TransformBundle>(); |
There was a problem hiding this comment.
I meant just to keep the transform bundle when both picked and not picked and toggle visibility, but we can always change it later if we need to use the transform for animations in the future. Probably unnecessary for now 👍
There was a problem hiding this comment.
ok. if we put it in the animations or something, then it will certainly go back 😄 it is unnecessary now, since if we put it in the HUD (there is a tracking issue), the HUD uses different semnantics/types anyway.
Base version: Multiple items can be picked; items are never released.
WATCH OUT! This may allow throwing and shooting a bottle in the same frame. See [related discussion](fishfolk#83 (comment)).
64kramsystem
force-pushed
the
add_items_picking_2
branch
from
43c2f3f
to
39818cd
Compare
|
Ok. Ready for review and hopefully merge. Implemented the change requested in one comment, and resolved the other comment without change. |
|
bors merge |
|
Build succeeded: |
Add items picking logic:
A minor but subtle bug is also fixes see 7e22c45.
Also note the side effect described in d7cdbbf.
Closes #83.