Remove orphan Panning component and related code #104
Conversation
|
I touched a lot of the input stuff with #100 including removing the camera controls so it's probably easier to do this after that merges so that I don't have to deal with merge conflicts on the big PR. I think I've almost got that finished, just needs a couple small fixes to the button adjacency map. I removed most of the unneeded camera stuff in #100 but I see you also modified |
|
|
||
| let max_player_x_diff = | ||
| max_player_x - camera.translation.x - game_meta.camera_move_right_boundary; | ||
|
|
||
| if max_player_x_diff > 0. { | ||
| // The x axis is handled by the parallax plugin. | ||
| camera.translation.y = consts::GROUND_Y + panning.offset.y; | ||
| // The y axis value doesn't change. |
There was a problem hiding this comment.
These changes should still be made, but most of the other changes were already done in #100.
README.md
Outdated
| @@ -20,8 +20,6 @@ https://fishfight.github.io/punchy/demo/ | |||
| | Throw Item | C | Period | West | | |||
There was a problem hiding this comment.
Maybe we should totally remove the controller input binding list here?
Users can now view/change the bindings in the game, and it's always easy to forget to update the readme when we add/remove a new move or we change the bindings.
There was a problem hiding this comment.
I think it would be fine to remove now that its possible to see in the controller settings menu.
There was a problem hiding this comment.
Makes sense. I'll integrate this once I rebase/rework the PR 😄
Controls can now be customized, so maintaining a dedicated section gives very little value.
64kramsystem
force-pushed
the
remove_camera_manual_commands
branch
from
0ed4798
to
4f87c7d
Compare
64kramsystem
changed the title
Remove the now orphan Panning component and related code.
Also remove the controls section from the README.