Use eslint-disable-next-line instead of eslint-ignore

firebase · Jul 22, 2024 · 8758d33 · 8758d33
1 parent d056f94
commit 8758d33
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/analytics/src/helpers.ts b/packages/analytics/src/helpers.ts
@@ -185,7 +185,7 @@ async function gtagOnEvent(
     // if not all entries in the 'send_to' field could be mapped to
     // a FID. In these cases, wait on all pending initialization promises.
     if (initializationPromisesToWaitFor.length === 0) {
-      /* eslint-disable @typescript-eslint/no-floating-promises */
+      /* eslint-disable-next-line @typescript-eslint/no-floating-promises */
       initializationPromisesToWaitFor = Object.values(
         initializationPromisesMap
       );

diff --git a/packages/auth-compat/test/helpers/helpers.ts b/packages/auth-compat/test/helpers/helpers.ts
@@ -17,7 +17,7 @@
 
 import * as sinon from 'sinon';
 import firebase from '@firebase/app-compat';
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable-next-line import/no-extraneous-dependencies */
 import '@firebase/auth-compat';
 import { Provider } from '@firebase/component';
 import '../..';

diff --git a/packages/firestore/src/util/async_queue_impl.ts b/packages/firestore/src/util/async_queue_impl.ts
@@ -286,7 +286,7 @@ export class AsyncQueueImpl implements AsyncQueue {
     // Note that draining may generate more delayed ops, so we do that first.
     return this.drain().then(() => {
       // Run ops in the same order they'd run if they ran naturally.
-      /* eslint-disable @typescript-eslint/no-floating-promises */
+      /* eslint-disable-next-line @typescript-eslint/no-floating-promises */
       this.delayedOperations.sort((a, b) => a.targetTimeMs - b.targetTimeMs);
 
       for (const op of this.delayedOperations) {
@@ -311,8 +311,8 @@ export class AsyncQueueImpl implements AsyncQueue {
   private removeDelayedOperation(op: DelayedOperation<unknown>): void {
     // NOTE: indexOf / slice are O(n), but delayedOperations is expected to be small.
     const index = this.delayedOperations.indexOf(op);
-    /* eslint-disable @typescript-eslint/no-floating-promises */
     debugAssert(index >= 0, 'Delayed operation not found.');
+    /* eslint-disable-next-line @typescript-eslint/no-floating-promises */
     this.delayedOperations.splice(index, 1);
   }
 }