Fix release script. #1602
Merged
Fix release script. #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, release script is broken with error message:
```
node_modules/google-gax/build/src/fallback.d.ts:20:34 - error TS2724: '"google-auth-library"' has no exported member named 'AnyAuthClient'. Did you mean 'AuthClient'?
20 import { GoogleAuth, AuthClient, AnyAuthClient } from 'google-auth-library';
```
It looks like the issue is related to some odd type incompatibility issue in an upstream package (google-gax). Rather than wait for the issue to be resolved, the change here removes command to install firebase-admin which isn't needed to build the release package anyway.
joehan
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, release script is broken with error message:
It looks like the issue is related to some odd type incompatibility issue in an upstream package (google-gax). Rather than wait for the issue to be resolved, the change here removes command to install firebase-admin which isn't needed to build the release package anyway.