Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking-fn-sms-final #1589

Open
wants to merge 6 commits into
base: blidd.blocking-fn-email-final
Choose a base branch
from

Conversation

pragatimodi
Copy link

@pragatimodi pragatimodi commented Aug 5, 2024

Adding changes for beforeSendSms blocking function support

@pragatimodi pragatimodi changed the base branch from master to blidd.blocking-fn-email-final August 5, 2024 23:19
@pragatimodi pragatimodi changed the base branch from blidd.blocking-fn-email-final to master August 20, 2024 00:22
@pragatimodi pragatimodi changed the base branch from master to blidd.blocking-fn-email-final August 20, 2024 00:41
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1 +1 @@
- Add support for beforeEmailSent auth blocking triggers. (#1492)
- Add support for beforeSmsSent auth blocking triggers. (#1589)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe merge these 2 change log together since they will be merged to master together.

Copy link
Contributor

@blidd-google blidd-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants