Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS origins of an array of one are made a scalar. #1536

Merged
merged 2 commits into from
Mar 19, 2024

Commits on Mar 8, 2024

  1. CORS origins of an array of one are made a scalar.

    The access-control-allowed-origins CORS header only allows
    a single origin or "*" as its response. To support multiple origins,
    the cors middleware makes this header dynamic based on the origin
    header of the request when the middleware is configured with anything
    but a single string.
    
    To help avoid a few edge cases customers may encounter, we can unwrap
    an array of one element into a scalar to encourage the cors middleware
    to make the access-control-allowed-origin header static.
    
    As a very minor performance boost, this change also instantiates the
    cors middleware once and uses it on all requests rather than
    constructing it dynamically within a request.
    inlined committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0f11d6f View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Configuration menu
    Copy the full SHA
    daf2c40 View commit details
    Browse the repository at this point in the history