Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emitting eventarc channels as params #1313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Berlioz
Copy link
Contributor

@Berlioz Berlioz commented Nov 16, 2022

As far as interesting PRs go, this ain't it, chief.

Though I have to say it's a little surprising that we define channel as a possible field on the base EventOptions class, despite it only being meaningful to have in one type of Event trigger option? That seems like not how classes should work, unless I'm really missing something about Typescript?

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as interesting PRs go, this ain't it, chief.Though I have to say it's a little surprising that we define channel as a possible field on the base EventOptions class, despite it only being meaningful to have in one type of Event trigger option? That seems like not how classes should work, unless I'm really missing something about Typescript?

Yeah maybe custom event should've been it's own trigger type, like scheduledTrigger or taskQueueTrigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants